[X] deprecate fontImageExtension#23657
Merged
jfversluis merged 3 commits intonet10.0from Feb 10, 2025
Merged
Conversation
StephaneDelcroix
changed the title
rmarinho
previously requested changes
Jul 17, 2024
Member
rmarinho
left a comment
rmarinho
left a comment
There was a problem hiding this comment.
You need to add REMOVE in the unpublished public api not removed them for the PublicAPI .
Also a change to remove something don t you think should be targeting net9 ?
StephaneDelcroix
force-pushed
the
fix_23347
branch
from
5b9ccd8 to
8b0761d
Compare
Contributor
Author
|
@rmarinho fixed |
Member
|
Please rebase on net10.0 branch |
StephaneDelcroix
force-pushed
the
fix_23347
branch
from
8b0761d to
65ead01
Compare
Contributor
Author
done |
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
bot
force-pushed
the
fix_23347
branch
from
65ead01 to
88178f2
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as off-topic.
This comment was marked as off-topic.
The passthrough markup extensions serves no purposes, and isn't as
flexible as the complete FontImageSource (allowing bindings,
dynamicresources, ...)
For convenience, the element syntax can be used as a markup syntax
{FontImagesource}
- fixes #23347
jfversluis
force-pushed
the
fix_23347
branch
from
11f4382 to
5648858
Compare
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
jfversluis
approved these changes
Feb 10, 2025
Contributor
|
🚨 API change(s) detected @davidbritch FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
The passthrough markup extensions serves no purposes, and isn't as flexible as the complete FontImageSource (allowing bindings, dynamicresources, ...)
For convenience, the element syntax can be used as a markup syntax {FontImagesource}
Issues Fixed